New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile of 3.6.0-rc3 against kernel 4.20.x #271

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@paradon
Copy link
Contributor

paradon commented Dec 31, 2018

A pair of logging functions in src/mod/nat64/bib/db.c were using 'time_to_tm()' which was removed in 4.20.0.

This patch updates those calls to 'time64_to_tm()', and also updates the related calls to the deprecated 'do_gettimeofday()' to use 'ktime_get_real_seconds()' instead.

Fix deprecated time calls to fix compile against 4.20.x
A pair of logging functions in src/mod/nat64/bib/db.c were using
'time_to_tm()' which was removed in 4.20.0.

This commit updates those calls to 'time64_to_tm()', and also
updates the related calls to the deprecated 'do_gettimeofday()'
to use 'ktime_get_real_seconds()' instead.
@ydahhrk

This comment has been minimized.

Copy link
Member

ydahhrk commented Jan 2, 2019

Hi

Sorry about the silence; still savoring those vacations. I will review and merge this PR tomorrow.

Thank you!

@ydahhrk ydahhrk merged commit 7f73ff9 into NICMx:issue140-iptables Jan 3, 2019

@ydahhrk

This comment has been minimized.

Copy link
Member

ydahhrk commented Jan 3, 2019

Ran the test suite on kernel 4.20.0-042000-generic. The latest commit of Jool 3.6.0 is working fine there.

@ydahhrk

This comment has been minimized.

Copy link
Member

ydahhrk commented Jan 3, 2019

@paradon: Do you want credits in Jool's README?

@paradon

This comment has been minimized.

Copy link
Contributor

paradon commented Jan 3, 2019

@ydahhrk Sure, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment