Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDNs in the zone table #103

Open
huwsteadCL opened this issue Aug 16, 2019 · 6 comments
Open

IDNs in the zone table #103

huwsteadCL opened this issue Aug 16, 2019 · 6 comments

Comments

@huwsteadCL
Copy link

In regards to the zone table should IDNs be added as punycode (i.e. xn--)?

We have a number of IDN tlds and when we try and retrieve from a domain query (in which the extension is provided as punycode) we get a "Zone not found"

Also as a side question I assume that we shouldn't us using punycode conversion when adding in a domain name to the domain.dom_unicode_name field?

@dhfelix
Copy link
Contributor

dhfelix commented Aug 16, 2019

In regards to the zone table should IDNs be added as punycode (i.e. xn--)?
We have a number of IDN tlds and when we try and retrieve from a domain query (in which the extension is provided as punycode) we get a "Zone not found"

The code needs a fix to support IDN in zones.

Also as a side question I assume that we shouldn't us using punycode conversion when adding in a domain name to the domain.dom_unicode_name field?

When the code asks for a domain in the database, the domain query information is sent as u-label, so the domain information in the database must be in u-label.

@huwsteadCL
Copy link
Author

When the code asks for a domain in the database, the domain query information is sent as u-label, so the domain information in the database must be in u-label.

But I assume the query itself from a URL standpoint can be the Punycode variant?

@dhfelix
Copy link
Contributor

dhfelix commented Aug 16, 2019

yes, the user can ask as a-label or u-label, in fact the server module just check if it is a valid domain name, our rdap-sql-provider searches in the db in u-label only.

dhfelix added a commit to NICMx/rdap-sql-provider that referenced this issue Aug 23, 2019
@dhfelix dhfelix reopened this Aug 23, 2019
@dhfelix dhfelix added the Solved label Aug 23, 2019
@dhfelix
Copy link
Contributor

dhfelix commented Aug 23, 2019

I just release a new version of RDAP-core.jar and Rdap-sql-provider.jar , replace your old Jars with the new ones, and thats it, it should work.

I still need to update the documentation, and maybe update the rdap-server.war with this new jars

@huwsteadCL
Copy link
Author

Thanks @dhfelix

In regards to the zone.zone_name should be zone name be stored as a-label or u-label in the database?

@dhfelix
Copy link
Contributor

dhfelix commented Aug 30, 2019

Oh right, my bad sorry, It should be stored in u-label format.
I think it will have the same problem as the issue #106, let me check in our test environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants