Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The is_reverse_ipv#_enabled options don't really belong to the server's configuration #29

Closed
ydahhrk opened this issue May 15, 2017 · 2 comments

Comments

@ydahhrk
Copy link
Member

ydahhrk commented May 15, 2017

The reason why is_reverse_ipv4_enabled and is_reverse_ipv6_enabled exist is because these searches can be expensive.

But that's only assuming the SQL provider is being used with default queries. I don't think it's sensible for the server to be making assumptions regarding the data access implementation's performance.

These keys belong to the SQL provider.

pcarana added a commit that referenced this issue Sep 21, 2017
…everse search configuration (fix #29). The default behavior for the zones is to manage everything.
@pcarana pcarana added this to the v1.1.3 milestone Sep 22, 2017
@pcarana pcarana added the Solved label Sep 22, 2017
@pcarana
Copy link
Contributor

pcarana commented Oct 2, 2017

Agree, this has been moved to the provider.

@TheRedTrainer
Copy link

Verified. The is_reverse_ipv4_enabled and is_reverse_ipv6_enabled properties were moved to data-access.properties file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants