Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zone validation is case sensitive in domain search #42

Closed
pcarana opened this issue Jul 6, 2017 · 2 comments
Closed

Zone validation is case sensitive in domain search #42

pcarana opened this issue Jul 6, 2017 · 2 comments

Comments

@pcarana
Copy link
Contributor

pcarana commented Jul 6, 2017

Assuming that the server has configured the zone "bar" at configuration.properties, it will only allow the search of domains of such zone (nothing new). The issue appears when the zone of the searched domain isn't literally "bar". This is easier to explain with an example, if the following search is made:
/domain/foo.bar
assuming that "foo.bar" exists in my database, the response code will be 200 (OK). But if the search is:
/domain/foo.BAR
the response will be 404 (Not found), and in the body will contain the text "The zone is unmanaged by this server.".

The zones are loaded in the application just as they are written in the configuration file (mx.nic.rdap.server.RdapConfiguration.validateConfiguredZones()), so whenever they are validated (isValidZone(String) or even at isValidReverseAddress(String)) the validation will succeed if it's an exact match. I would suggest that the zone can be case insensitive.

@pcarana
Copy link
Contributor Author

pcarana commented Oct 2, 2017

The configured zones are now case insensitive.

@TheRedTrainer
Copy link

Verified. If you search the example.org domain as "domain/example.ORG" or "domain/example.org", the search brings the same results because now the validation is case insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants