Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error description isn't returned as array #51

Closed
pcarana opened this issue Sep 6, 2017 · 3 comments
Closed

Error description isn't returned as array #51

pcarana opened this issue Sep 6, 2017 · 3 comments

Comments

@pcarana
Copy link
Contributor

pcarana commented Sep 6, 2017

According to RFC 7483 section 6:

The basic structure of that response is an object class containing an
error code number (corresponding to the HTTP response code) followed
by a string named "title" and an array of strings named
"description".

Currently the description is returned as a string, not as an array of strings.

Eg. the response to "/ip/..." is:

{
	"rdapConformance": [
		"rdap_level_0"
	],
	"errorCode": "400",
	"description": "Invalid IPv4 address : ..."
}
@pcarana pcarana added this to the v1.1.3 milestone Sep 22, 2017
@pcarana
Copy link
Contributor Author

pcarana commented Nov 2, 2017

The renderized is now handled by NICMx/rdap-renderer-api, which is implemented in NICMx/rdap-json-renderer and used by the server. So, the fix has been done at the JSON Renderer.

@pcarana pcarana added the Solved label Nov 2, 2017
@TheRedTrainer
Copy link

Verified. The description is displayed as a string array:

{
"rdapConformance": [
"rdap_level_0"
],
"errorCode": "400",
"description": [
"Invalid IPv4 address : ..."
]
}

@pcarana
Copy link
Contributor Author

pcarana commented Nov 9, 2017

Closing, fixed in Red Dog v1.2

@pcarana pcarana closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants