Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderers.properties doesn't include a default configuration #65

Closed
TheRedTrainer opened this issue Oct 17, 2017 · 2 comments
Closed

renderers.properties doesn't include a default configuration #65

TheRedTrainer opened this issue Oct 17, 2017 · 2 comments

Comments

@TheRedTrainer
Copy link

The renderers.properties configuration file includes an empty default configuration. If the user doesn't define a renderer class, the server cannot start.

It's highly recommended to include a default configuration in order to help the new users to configure and test rdap-server more easily.

@pcarana pcarana added this to the v1.2.0 milestone Oct 17, 2017
@dhfelix
Copy link
Contributor

dhfelix commented Oct 18, 2017

The properties file does not contain hidden default values, it is necessary for the user to configure at least one renderer.

To start the rdap-server server quickly, we decided to leave the reference implementation of the json-renderer and its corresponding configuration in the renderers.properties file. The user is free to remove the reference implementation and change the configuration of this properties file to use the renderer of his choice.

@dhfelix dhfelix added the Solved label Oct 18, 2017
@TheRedTrainer
Copy link
Author

Verified. The renderer properties file includes a default renderer with all the regarding configuration (class, main_mime, mimes) in order to start the server quickly with a reference renderer implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants