Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy settings for ds_data load properties from key_data file instead #70

Closed
TheRedTrainer opened this issue Oct 26, 2017 · 2 comments
Assignees
Milestone

Comments

@TheRedTrainer
Copy link

In DomainPrivacyFilter class, when the privacy settings for dsData is loaded, there is a mistake that loads the keyData privacy settings instead (according to the following line codes):

... (281)
private static boolean filterDomainDsData(List dsDatas, UserInfo userInfo) {
boolean isPrivate = false;

  if (ObjectPrivacyFilter.isValueEmpty(dsDatas)) {
  	return isPrivate;
  }

Map<String, PrivacySetting> privacySettings = PrivacyUtil.getKeyDataPrivacySettings();
...

@pcarana pcarana added this to the v1.2.0 milestone Oct 26, 2017
@dhfelix dhfelix added the Solved label Oct 26, 2017
@dhfelix
Copy link
Contributor

dhfelix commented Oct 26, 2017

You are right, PrivacyUtil.getDsDataPrivacySettings() should be loaded instead of keyDataPrivacySettings

@TheRedTrainer
Copy link
Author

Verified. The privacy settings are loaded from ds data file, instead of key data file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants