Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we keep regex searches code in rdap-server? #76

Closed
TheRedTrainer opened this issue Dec 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@TheRedTrainer
Copy link

commented Dec 2, 2017

Currently, the code that allows to execute searches using regex as it is defined in "Registration Data Access Protocol (RDAP) Search Using POSIX Regular Expressions" draft ( https://tools.ietf.org/html/draft-fregly-regext-rdap-search-regex-00.html ) is included in rdap-server; however, as far as I know, this functionality is neither mentioned nor supported in rdap documentation. The code could work but it wasn't tested.

Should rdap-server keep this code (keeping also the development and testing efforts) and provide support? Or should we remove all the code and functionality?

@pcarana

This comment has been minimized.

Copy link
Collaborator

commented Dec 8, 2017

Well, the code is there but definitely out of date. The implementation is based on version 1 of the draft; today the draft is at version 3. Version 2 had some major changes that the server doesn't have.

The reason why this has been implemented even before the draft became a RFC, is that the draft had potential to achieve the goal of becoming a RFC.

Should rdap-server keep this code (keeping also the development and testing efforts) and provide support? Or should we remove all the code and functionality?

This depends on the draft's evolution, for now the server will keep it (it's a hidden gem that can be valued in the future). The documentation will stay the same.

@pcarana

This comment has been minimized.

Copy link
Collaborator

commented Dec 12, 2017

Just to avoid problems, a new configuration flag has been added: allow_regex_searches. This will enable/disable the use of regex searches that the server currently supports; the behavior is disabled by default.

@pcarana pcarana added this to the v1.2.2 milestone Dec 12, 2017

@pcarana pcarana self-assigned this Dec 12, 2017

@pcarana pcarana added the Solved label Dec 12, 2017

@pcarana pcarana closed this in a338955 Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.