Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review intel:PersonAugmentationType #114

Closed
cdmgtri opened this issue Feb 11, 2020 · 1 comment
Closed

Review intel:PersonAugmentationType #114

cdmgtri opened this issue Feb 11, 2020 · 1 comment

Comments

@cdmgtri
Copy link
Collaborator

cdmgtri commented Feb 11, 2020

intel:PersonAugmentationType

Property Recommendation
intel:AgencySubjectInterest Recommend renaming as "PersonAgencyInterest"
intel:PersonCitizenshipDetails Recommend creating a more reusable citizenship type and nationality type in Core, and removing this element. See below for more.
intel:PersonContactDetails Recommend removing. The data type is nc:ContactInformationType. This information is already available in nc:PersonType.
intel:PersonEducationDetails See #113 (Review education-related components) for recommendation to remove.
nc:Location Recommend removing nc:Location in favor of the existing nc:PersonLocationAssociation.
intel:PersonMultimediaIDBinary
intel:PersonSystemIdentification
intel:PersonCauseOfDeathText Recommend removing intel:PersonCauseOfDeathText in favor of the cause-of-death related components in the Justice domain.
intel:PersonEyeDescriptionText
intel:OccupationName Recommend adding class term "Person" to name.
nc:Aircraft Recommend removing nc:Aircraft and nc:Vessel.
There are existing associations that should capture these sematics (nc:ItemEntityAssociation, nc:ItemOwnerAssociation, j:PersonAssetItemAssociation), or new properties could be added if still needed with more descriptive semantics.
nc:Vessel See recommendation for nc:Aircraft

Recommendation of intel:PersonCitizenshipDetails

This component currently contains the following:

  • intel:PersonCitizenshipDetails
    • nc:PersonCitizenshipAbstract
    • intel:PersonCitizenshipStatusCodeText

nc:PersonCitizenshipAbstract is already available in nc:PersonType, but there is no way to group it with status information.

Recommendation

Recommend creating a citizenship type and a nationality type in Core. This would make it easy for domains and IEPDs to attach additional properties while being able to leverage what's already there.

nc:PersonCitizenship

  • nc:PersonCitizenshipCountry (nc:CountryType)
  • nc:PersonCitizenshipCategoryAbstract
    • nc:PersonCitizenshipCategoryText
  • nc:PersonCitizenshipStatus (nc:StatusType)

nc:PersonNationality

  • nc:PersonNationalityCountry (nc:CountryType)
  • nc:PersonNationalityCategoryAbstract
    • nc:PersonNationalityCategoryText
  • nc:PersonNationalityStatus (nc:StatusType)

See related issue #93 for use nc:CountryType for citizenship and nationality codes.

See related issue #124 for a specific issue about breaking out new citizenship and nationality types.

@cdmgtri cdmgtri added this to the niem-5.0alpha1 milestone Feb 11, 2020
@cdmgtri cdmgtri added this to To do in NIEM-5.0 via automation Feb 11, 2020
@cdmgtri cdmgtri moved this from To do to Harmonization Workgroup in NIEM-5.0 Feb 11, 2020
@cdmgtri cdmgtri moved this from Harmonization Workgroup to Pending Review in NIEM-5.0 Feb 25, 2020
@cdmgtri
Copy link
Collaborator Author

cdmgtri commented Feb 25, 2020

The Harmonization Workgroup recommends the proposed changes.

@cdmgtri cdmgtri moved this from Pending Review to Approved in NIEM-5.0 Mar 19, 2020
cdmgtri pushed a commit to cdmgtri/NIEM-Releases that referenced this issue Mar 31, 2020
@cdmgtri cdmgtri closed this as completed Mar 31, 2020
NIEM-5.0 automation moved this from Approved to Done Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
NIEM-5.0
  
Done
Development

No branches or pull requests

1 participant