nemu,device: poll the SDL event out of the signal handler #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SDL_PollEvent() may eventually call malloc(), therefore it is not async singal safe, which may cause deadlock in malloc(). * timer_intr() should be called in the signal handler, else hlt() will get stuck. * Now device_update() should be called in the for loop of cpu_exec() to finish the bottom half of the signal handler. * This patch will fix issue #4.
ghost
pushed a commit
that referenced
this pull request
Feb 22, 2016
nemu,device: poll the SDL event out of the signal handler
ghost
merged commit 
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not async singal safe, which may cause deadlock in malloc().
will get stuck.
to finish the bottom half of the signal handler.