Repository navigation
Add XFR middleware. - #384
Merged
Merged
Conversation
ximon18
marked this pull request as ready for review
September 10, 2024 09:20
- Renamed AuthenticatedRequestMessage to RequestMessage to be consitent with src::net::client::request and to shorten the name (as it is scoped by the module so is still unique). - Renamed UpstreamSender to Forwarder as it's shorter and (I thnk) better. - Replaced HandleResponseResult by Option. - Renamed handle_response() to validate_response() and simplified the option/error handling a little. - Moved some impls around in the file to be nearer the type they affect.
…ion of tsig mod KeyStore changes which is good anyway as they would have been breaking changes to stable interfaces.
…r secondary and doing zone maintenance.
…a hard-coded TSIG key and printing of received NOTIFY triggers.
Philip-NLnetLabs
approved these changes
Oct 2, 2024
ximon18
added a commit
that referenced
this pull request
Oct 3, 2024
Add XFR middleware and: - Fixes a bug where the incorrect owner name was passed to the zone walker callback. - New `ixfr-client.rs` example. - Updated `serve-zone.rs` example demonstrating TSIG authenticated XFR and NOTIFY middlewares. - Additional From impls for CallResult. - Renames ZoneDiff to InMemoryZoneDiff. - Renames ZoneDiffBuilder to InMemoryZoneDiffBuilder. - Introduces new ZoneDiff and related traits. - Adds AnswerContent::first().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extraction of
XfrMiddlewareSvcfrom thexfrbranch and conversion such that access control checks are no longer hard-coded into the middleware nor dependent on policy data being stored in a specific form, and renamesZoneDifftoInMemoryZoneDiffand adds aZoneDifftrait to remove the fixed use of in-memory diffs byXfrMiddlewareSvc.Notes about the changes to
src/zonetree/in_memory/read.rs:Changes in
read.rsare just cleaning up:query_node_here_and_below()it now only invokes the walker if actually enabled, though nothing was actually broken by not checking for this (as when not enabled it does nothing), this change just makes the code more consistent with other code inread.rs.query_node_here_but_not_below()calls to the walker have been removed, but only because they never get invoked anyway, as the only caller of this fn only calls if it not walking.