Shivan Kaul XoT review - #183
Merged
Merged
Conversation
- Requires TLS 1.3 support - Uses a new `tls-auth` clause in the `request-xfr` pattern to specify the authentication domain name to use.
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
Re-add close(fd) instead of shutdown
- move 2 log messages to after EOF - clean up some whitespace
…ect error line is reported and confcheck unit test now passes Add 1 zone to confcheck unit text to include XoT
… for a given zone
Also if they are about certificate verification failure which might already have been reported before, because otherwise some certificate verification failures may go unreported (like missing CA).
wcawijngaards
approved these changes
Jul 8, 2021
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
The code looks good to merge. The nsd-control ports in the tdir test are unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are nits that came out of reviewing client side XoT from @ShivanKaul and @saradickinson .
I am planning to create a tpkg test for it. For that it is convenient to have a
tls-cert-bundlelike how that exists in Unbound, so I'll create an option for that first.