Add support for LOC RR #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Any chance that this can be vectorized for better perf? |
Contributor
Author
|
Maybe, but it'd be complex because it contains a lot of optional fields (e.g. minutes + seconds in latitude and longitude), so there's always going to be a lot branches? The LOC RRTYPE afaik also isn't used much(?) So, it might be a fun experiment, but it'll probably only benefit really specific use cases(?) If you're just looking for any fun experiment, there's other data types that benefit from vectorization more. e.g. ipv6 or eui48/eui64 (MAC addresses). Those data types are more straightforward and probably more interesting in general (though EUIxx isn't used much in DNS either, but the address format is used in other places too)? |
Collaborator
|
Ok. I will look at ipv6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the LOC RR defined in RF1876. Still needs some basic tests to verify logic.