Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential memory corruption due to size miscomputation upton custom region alloc init #320

Closed
magenbluten opened this issue Oct 8, 2020 · 1 comment
Closed

potential memory corruption due to size miscomputation upton custom region alloc init #320

magenbluten opened this issue Oct 8, 2020 · 1 comment
Assignees
@gthess

Comments

@magenbluten
Copy link
Contributor

here we allocate a fresh region with a user provided size value:

unbound/util/regional.c

Line 86 in 52b0480

struct regional* r = (struct regional*)malloc(size);

this size value gets aligned to the neccessary alignment requirements. but this happens after the malloc. thus size
can now be larger than what was actually allocated:

unbound/util/regional.c

Line 87 in 52b0480

size = ALIGN_UP(size, ALIGNMENT);

unbound/util/regional.c

Line 90 in 52b0480

r->first_size = size;

@gthess gthess closed this as completed in 0272889 Oct 21, 2020
@gthess gthess self-assigned this Oct 21, 2020
@gthess
Copy link
Member

gthess commented Oct 21, 2020

Seems like it indeed, thanks!

jedisct1 added a commit to jedisct1/unbound that referenced this issue Nov 1, 2020
@jedisct1
Merge remote-tracking branch 'nlnet/master'
c034da7 
* nlnet/master: (81 commits)
  - In man page note that tls-cert-bundle is read before permission   drop and chroot.
  - Fix that minimal-responses does not remove addresses from a priming   query response.
  - Fix NLnetLabs#333: Unbound Segmentation Fault w/ log_info Functions From   Python Mod.
  - Fix NLnetLabs#320: potential memory corruption due to size miscomputation upton   custom region alloc init.
  - Fix NLnetLabs#327: net/if.h check fails on some darwin versions; contribution by   Joshua Root.
  Add verbosity to debug occasional missing q1-10.example.net, from timer.
  Changelog note for NLnetLabs#228 - Merge PR NLnetLabs#228 : infra-keep-probing option to probe hosts that are   down.  Add infra-keep-probing: yes option. Hosts that are down are   probed more frequently.   With the option turned on, it probes about every 120 seconds,   eventually after exponential backoff, and that keeps that way. If   traffic keeps up for the domain. It probes with one at a time, eg.   one query is allowed to probe, other queries within that 120 second   interval are turned away.
  - Changelog entry for PR NLnetLabs#324: Add modern X.509v3 extensions to   unbound-control TLS certificates, by James Renken.
  - Fix for attaching the X509v3 extensions to the client certificate.
  - Clean the fix for out of order TCP processing limits on number   of queries.  It was tested to work.
  Fixup for clear of tcp handler structure.
  - Fix to set the tcp handler event toggle flag back to default when   the handler structure is reused.
  Changelog entry for local-zone out of chunk regional allocation
  - Log ip address when http session recv fails, eg. due to tls fail.
  Unit test for doh downstream notls.
  - Fix dnstap test to wait for log timer to see if queries are logged.
  - Fix python documentation warning on functions.rst inplace_cb_reply.
  - Fix NLnetLabs#330: [Feature request] Add unencrypted DNS over HTTPS support.   This adds the option http-notls-downstream: yesno to change that,   and the dohclient test code has the -n option.
  - Fix memory leak of https port string when reading config.
  - Fix that http settings have colon in set_option, for   http-endpoint, http-max-streams, http-query-buffer-size,   http-response-buffer-size, and http-nodelay.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gthess gthess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magenbluten @gthess