dnstap does not log the DNS message ID for FORWARDER_QUERY

[fhriley]

I'm seeing an ID of 0 for FORWARDER_QUERY dnstap messages. The FORWARDER_RESPONSE does contain the ID as do all of the CLIENT_QUERY and RESOLVER_QUERY message types. See example below (decoded using https://github.com/dnstap/golang-dnstap/tree/master/dnstap). Shouldn't the forwarder query have a non-zero ID? I'm using unbound 1.13.0.

type: MESSAGE
message:
  type: FORWARDER_QUERY
  query_time: !!timestamp 2020-12-09 21:40:22.415342
  socket_family: INET
  socket_protocol: TCP
  response_address: 1.1.1.1
  response_port: 853
  query_zone: "."
  query_message: |
    ;; opcode: QUERY, status: NOERROR, id: 0   <------------------------------------ ID is 0?
    ;; flags: rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

    ;; QUESTION SECTION:
    ;itunes.apple.com.edgekey.net.      IN       HTTPS

    ;; ADDITIONAL SECTION:

    ;; OPT PSEUDOSECTION:
    ; EDNS: version 0; flags: do; udp: 1472

type: MESSAGE
message:
  type: FORWARDER_RESPONSE
  query_time: !!timestamp 2020-12-09 21:40:22.414892
  response_time: !!timestamp 2020-12-09 21:40:22.44134
  socket_family: INET
  socket_protocol: TCP
  response_address: 1.1.1.1
  response_port: 853
  query_zone: "."
  response_message: |
    ;; opcode: QUERY, status: NOERROR, id: 6959   <------------------------------------ ID is non-zero
    ;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 1, ADDITIONAL: 1

    ;; QUESTION SECTION:
    ;itunes.apple.com.edgekey.net.      IN       HTTPS

    ;; ANSWER SECTION:
    itunes.apple.com.edgekey.net.       21423   IN      CNAME   e673.dsce9.akamaiedge.net.

    ;; AUTHORITY SECTION:
    dsce9.akamaiedge.net.       823     IN      SOA     n0dsce9.akamaiedge.net. hostmaster.akamai.com. 1607549848 1000 1000 1000 1800

    ;; ADDITIONAL SECTION:

    ;; OPT PSEUDOSECTION:
    ; EDNS: version 0; flags: do; udp: 1232
    ; PADDING: 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

[fhriley]

I switched my forward servers to UDP and now the messages have the ID filled in. This issue appears to be specific to forward queries over TCP.

type: MESSAGE
message:
  type: FORWARDER_QUERY
  query_time: !!timestamp 2020-12-09 23:11:49.122505
  socket_family: INET
  socket_protocol: UDP
  response_address: 1.1.1.1
  response_port: 53
  query_zone: "."
  query_message: |
    ;; opcode: QUERY, status: NOERROR, id: 23670
    ;; flags: rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

    ;; QUESTION SECTION:
    ;updates.istatmenus.app.    IN       A

    ;; ADDITIONAL SECTION:

    ;; OPT PSEUDOSECTION:
    ; EDNS: version 0; flags: do; udp: 1472

[wcawijngaards]

In the commit to the branch at #367 I have fixed the issue. A similar fix could be done to the main repo, but the branch also adds other features and touches the same code, so I put it there, so that if you get the code from that branch you have both the feature and the bugfix.
It was using a buffer without the ID value, at 0, but I updated it to use the buffer with the ID value in it.

[wcawijngaards]

The fixes have been merged in the code repository, and this should make the main codebase have a fix for this issue.