Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound-checkconf reports fatal error if interface names are used as value for interfaces: #574

Closed
ddt-consult opened this issue Nov 18, 2021 · 2 comments

Comments

@ddt-consult
Copy link

For a unbound.conf containing something like this:

server:
         interfaces: lo

unbound-checkconf will report a fatal error:
[1637242350] unbound-checkconf[25626:0] fatal error: cannot parse interface specified as 'lo'

unbound itself does work and respects the interface config option, though.
This happens with an unbound compiled from the unbound-1.13.2.tar.gz source provided on the download section of the nlnetlabs website.

@wcawijngaards
Copy link
Member

Fixed this, so that unbound-checkconf resolves the interface names, and checks if everything works fine, also for interface names. It also detects duplicate addresses, duplicate interface names and duplicate addresses from the resolution of the interface names. Thanks for the report!

@ddt-consult
Copy link
Author

Thanks for fixing this so quickly!

wcawijngaards added a commit that referenced this issue Nov 29, 2021
wcawijngaards added a commit that referenced this issue Nov 29, 2021
wcawijngaards added a commit that referenced this issue Nov 29, 2021
jedisct1 added a commit to jedisct1/unbound that referenced this issue Jan 13, 2022
* nlnet/master: (36 commits)
  - Add missing configure flags for optional features in the   documentation. - Fix Unbound capitalization in the documentation.
  - Fix to pick up other class local zone information before unlock.
  - Allow local-data for classes other than IN to inherit a configured   local-zone's type if possible, instead of defaulting to type   transparent as per the implicit rule.
  - Add code similar to fix for ldns for tab between strings, for   consistency, the test case was not broken.
  Continue with version 1.14.1
  - Fix validator debug output about DS support, print correct algorithm.
  Changelog note for NLnetLabs#581
  Fix -Wshadow
  Fix -Wmissing-prototypes by declaring functions static.
  - Fix compile warning for if_nametoindex on windows 64bit.
  - Fix doc/unbound.doxygen to remove obsolete tag warning.
  - configure is set to 1.14.0, and release branch.
  - Fix NLnetLabs#574: Review fixes for size allocation.
  - Fix NLnetLabs#454: listen_dnsport.c:825: error: ‘IPV6_TCLASS’ undeclared.
  Changelog note for NLnetLabs#530:     - Merge PR NLnetLabs#530 from Shchelk: Fix: dereferencing a null pointer.
  Changelog note for NLnetLabs#522:     - Merge PR NLnetLabs#522 from sibeream: memory management violations fixed.
  Changelog note for NLnetLabs#562:     - Merge PR NLnetLabs#562 from Willem: Reset keepalive per new tcp session.
  Changelog note for NLnetLabs#555:     - Merge PR NLnetLabs#555 from fobser: Allow interface names as scope-id in       IPv6 link-local addresses.
  Changelog note for NLnetLabs#493:     - Merge PR NLnetLabs#493 from Jaap: Fix generation of libunbound.pc.
  Changelog note for NLnetLabs#511:     - Merge PR NLnetLabs#511 from yan12125: Reduce unnecessary linking.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants