Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTBS] configure script error with libmnl on openSUSE 15.3 (and possibly other distributions) #684

Closed
Corin-EU opened this issue May 26, 2022 · 2 comments

Comments

@Corin-EU
Copy link

openSUSE 15.3 liibmnl-revel package puts the llibmnl header file ibmnl.h in /usr/include/libmnl/libmnl . I suspect the reason for the double sub-directory is because in previous incarnations, the upper sub-directory was versioned eg /usr/include/libnml-0.1

The issue #223 addressed the generic case of libmnl.h detection with the appropriate solution of using pkg-config to find the header file eg pkg-config --cflags libmnl but for unknown reasons that issue was closed without any comment or resolution.

The configure option "--with-libmnl=path specify explicit path for libmnl" to specify a path does not actually not do anything in respect of a path. The variable is only used to test if it has been set, not whether it has any value. One would expect ta variable to be something like --with-libmnl-includes and --with-libmlnl-libdir to specify paths to override pkg-config path searches.

This issue is present in the newest release 0.15.0, and on checking the very latest Github version of configure.ac, there is no change to the hard coded path searching with the use of pkg-config. In fact the configure.ac comments say ipkg-config is only used for the options enable_systemd, with_pyunbound, and with_pythonmod", and not to require it otherwise.

@wcawijngaards
Copy link
Member

The commit fixes it by testing for the particular header location. That should fix the issue for that choice. It then also sets an include flag for the interior include directory.

@Corin-EU
Copy link
Author

       opensuse 15.3

       git reflog  | head -n 1
      edc1d077 HEAD@{0}: clone: from https://github.com/NLnetLabs/unbound

      ./configure --enable-ipset

      grep mnl config.log
      configure:21717: checking for libmnl
      CPPFLAGS=' -I/usr/include/libmnl'
     LIBS='-lcrypto -lmnl'

Thank you for the very rapid fix. All is now working.

Presumably you have your reasons why you do not want to use pkg-config (maybe a transition from autotools to cmake is planned) to solve the issue in the general case.

jedisct1 added a commit to jedisct1/unbound that referenced this issue May 30, 2022
* nlnet/master:
  - Version is set to 1.16.0 for release. Release tag 1.16.0rc1.
  - Fix NLnetLabs#684: [FTBS] configure script error with libmnl on openSUSE 15.3 (and possibly other distributions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants