Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Missing documention in ub_resolve_event() for callback parameter was_ratelimited #779

Closed
jelu opened this issue Nov 11, 2022 · 2 comments

Comments

@jelu
Copy link

jelu commented Nov 11, 2022

As subject, doc says

void callback(void* mydata, int rcode, void* packet, int packet_len, int sec, char* why_bogus)

but code says

typedef void (ub_event_callback_type)(void, int, void*, int, int, char*, int);

missing the last int

@wcawijngaards
Copy link
Member

The commit adds the documentation to the header file, in the comment for ub_resolve_event. It is was_ratelimited. This is the same was_ratelimited that is also returned in the struct ub_result for queries.

Thank you for the detailed report!

@jelu
Copy link
Author

jelu commented Nov 11, 2022

Np Wouter! And thank you for the quick commit! 😄

jedisct1 added a commit to jedisct1/unbound that referenced this issue Nov 29, 2022
* nlnet/master:
  - Fix for the ignore of tcp events for closed comm points, preserve   the use after free protection features.
  - Ignore expired error responses.
  - Fix NLnetLabs#779: [doc] Missing documention in ub_resolve_event() for   callback parameter was_ratelimited.
  - Complementary fix for distutils.sysconfig deprecation in Python 3.10   to commit 62c5039.
  - iana portlist update.
  - Fix NLnetLabs#775: libunbound: subprocess reap causes parent process reap   to hang.
  - Fix to make sure to not read again after a tcp comm point is closed.
  - Fix to ignore tcp events for closed comm points.
  fix use after free when WSACreateEvent() fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants