Make fallthrough explicit for libworker.c#1110
Merged
wcawijngaards merged 1 commit intoNLnetLabs:masterfrom Jul 23, 2024
Merged
Make fallthrough explicit for libworker.c#1110wcawijngaards merged 1 commit intoNLnetLabs:masterfrom
wcawijngaards merged 1 commit intoNLnetLabs:masterfrom
Conversation
The code currently doesn't compile with LLVM's `-Wimplicit-fallthrough` flag, but the attribute works for both GCC (>=7) and LLVM.
wcawijngaards
approved these changes
Jul 23, 2024
Member
wcawijngaards
left a comment
wcawijngaards
left a comment
There was a problem hiding this comment.
It is nice, but the comment is there for other compilers. Also a feature test for the attribute is needed.
wcawijngaards
added a commit
that referenced
this pull request
Jul 23, 2024
fallthrough attribute annotations.
Contributor
Author
|
@wcawijngaards - thanks for being so thorough! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code currently doesn't compile with LLVM's
-Wimplicit-fallthroughflag, but the attribute works for both GCC (>=7) and LLVM.