Fix cache update when serve expired is used#1143
Merged
Conversation
still usable expired records. Modules are forbidden to update the cache if their answer is DNSSEC unchecked or bogus and a valid (expired) entry already exists. Bogus replies from the validator are also discarded in favor of existing (expired) valid replies.
wcawijngaards
approved these changes
Sep 24, 2024
Member
wcawijngaards
left a comment
wcawijngaards
left a comment
There was a problem hiding this comment.
Code looks good. It is nice to keep the better validated answers in cache when there are lookup failures.
gthess
added a commit
that referenced
this pull request
Sep 24, 2024
- Merge #1143: Fix cache update when serve expired is used. Expired records are favored over resolution and validation failures when serve-expired is used.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Sep 26, 2024
* nlnet/master: - Fix NLnetLabs#1144: [FR] log timestamps in ISO8601 format with timezone. This adds the option `log-time-iso: yes` that logs in ISO8601 format. Changelog entry for NLnetLabs#1143: - Merge NLnetLabs#1143: Fix cache update when serve expired is used. Expired records are favored over resolution and validation failures when serve-expired is used. Fix cache update when serve expired is used (NLnetLabs#1143) - More clear text for prefetch and minimal-responses in the unbound.conf man page. - Attempt to further fix doh_downstream_buffer_size.tdir flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By not replacing/evicting still usable expired records. Modules are forbidden to update the cache if their answer is DNSSEC unchecked or bogus and a valid (expired) entry already exists. Bogus replies from the validator are also discarded in favor of existing (expired) valid replies.
Fixes #994.