Stats for discard-timeout and wait-limit - #1159
Merged
Merged
Conversation
instead of the mesh dropped that of requests exceeded.
num.queries_wait_limit with unbound-control stats.
gthess
approved these changes
Nov 1, 2024
gthess
left a comment
gthess
left a comment
Member
There was a problem hiding this comment.
Looks good, useful statistics to differentiate between performance drops and configuration drops of packets.
gthess
added a commit
that referenced
this pull request
Nov 1, 2024
gthess
added a commit
that referenced
this pull request
Nov 1, 2024
- Some clean up for stat_values.test.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new discard-timeout and wait-limit options have been accounted as requestlist_exceeded in the statistics. But this mixes them with the request exceed number. The change makes their own statistics counters for them. The new statistics counters are
num.queries_discard_timeoutandnum.queries_wait_limit.