Serve expired cache update fixes#1174
Merged
Merged
Conversation
… of expired records.
enabled even without serve-expired-client-timeout.
wcawijngaards
approved these changes
Nov 6, 2024
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
Comments elsewhere, but approved. Important to have a limit on work for expired contents that is served, otherwise every incoming query could turn into an upstream request, a request attempt for failing lookups.
response cannot update the usable expired entry.
wcawijngaards
approved these changes
Nov 7, 2024
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
The changes look good! With serve expired, the norec_ttl is adjusted to stop repeated attempts, for a short duration, and the additional fix is a catch for additional cases where this is needed.
gthess
added a commit
that referenced
this pull request
Dec 31, 2024
- Merge #1174: Serve expired cache update fixes. Fixes a regression bug with serve-expired that appeared in 1.22.0 and would not allow the iterator to update the cache with not-yet-validated entries resulting in increased outgoing traffic.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 8, 2025
* nlnet/master: Changelog entry for NLnetLabs#1174: - Merge NLnetLabs#1174: Serve expired cache update fixes. Fixes a regression bug with serve-expired that appeared in 1.22.0 and would not allow the iterator to update the cache with not-yet-validated entries resulting in increased outgoing traffic. Serve expired cache update fixes (NLnetLabs#1174)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to fix certain things related to serve-expired and cache updates: