Unique DoT and DoH SSL contexts to allow for different ALPN - #1222
Merged
Conversation
wcawijngaards
approved these changes
Jan 16, 2025
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
This sets the ALPN right on listening SSL transports.
The ssl ticket keys, are now using the same list in memory and same config for both types of transport. I guess if the ticket key is there it can provide session resumption.
Member
Author
|
A couple of small additions for ALPN selection and optional context creation. |
gthess
added a commit
that referenced
this pull request
Jan 20, 2025
- Merge #1222: Unique DoT and DoH SSL contexts to allow for different ALPN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To follow the recent interoperability TLS fixes from NSD.
I would appreciate a second pair of eyes especially for the tls_session_ticket_keys.