Fix WSAPoll - #1265
Merged
Merged
Conversation
command to read from the fast_reload thread.
- Some systems return EAGAIN for poll.
gthess
marked this pull request as ready for review
April 11, 2025 12:53
wcawijngaards
approved these changes
Apr 11, 2025
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
The code looks good. The fixes make it more portable.
gthess
added a commit
that referenced
this pull request
Apr 11, 2025
* Fix calling WSAPoll. * fast_reload: explicitly set tcp_wouldblock on Windows when there is no command to read from the fast_reload thread. * For poll(), also check for ENOMEM (Linux). * Remove ifdefs for ENOMEM. * Some systems return EAGAIN for poll.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Apr 24, 2025
* nlnet/master: (49 commits) - Tag for 1.23.0rc2. This became the release of 1.23.0 on 24 April 2025. The code repository continues with 1.23.1 in development. - Increase default to `num-queries-per-thread: 2048`, when unbound is compiled with libevent. It makes saturation of the task queue more resource intensive and less practical. Thanks to Shiming Liu, Network and Information Security Lab, Tsinghua University for the report. Changelog entry for NLnetLabs#1265: - Merge NLnetLabs#1265: Fix WSAPoll. Fix WSAPoll (NLnetLabs#1265) Changelog entry for NLnetLabs#1265: - Merge NLnetLabs#1265: Fix WSAPoll. Fix WSAPoll (NLnetLabs#1265) - Fix for print of connection type in log-replies for dot and doh. - Fix NLnetLabs#1264: unbound 1.22.0 leaks memory when doing DoH. - Fix to detect if atomic_store links in configure. - Fix fast_reload to print chroot with config file name. - Update to the manpage for the fast_reload part. - Tag for 1.23.0rc1. - More explicit text about memory usage during fast_reload. Changelog entry for NLnetLabs#902: - Merge NLnetLabs#902: DNS Error Reporting (RFC 9567). Introduces new configuration option 'dns-error-reporting' and new statistics for 'num.dns_error_reports'. DNS Error Reporting (RFC 9567) (NLnetLabs#902) - Fix to update common.sh for speed of kill_pid. - Fix test to speed up common.sh script kill_pid. Fix typo in Changelog entry. Changelog entry for NLnetLabs#1019: - Merge NLnetLabs#1019: Redis read-only replica support. Introduces new 'redis-replica-*' options for the Redis cache backend. - Fix redis_replicat test for unused option defaults and log printout. ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.