Repository navigation
edns-subnet: fix NULL_AFTER_DEREF on subnetmod - #1297
Merged
Merged
Conversation
Found by static analyzer svace. Static analyzer message: Redundant comparison with a NULL value at subnetmod.c:236 for pointer 'sn_env->subnet_msg_cache', which was dereferenced at slabhash.c:228 by passing as 1st parameter to function 'slabhash_setmarkdel' at subnetmod.c:235. Moved usage of sn_env->subnet_msg_cache in slabhash_setmarkdel after checking. Signed-off-by: Konstantin Kamanin <bewflast@gmail.com>
wcawijngaards
approved these changes
Jun 19, 2025
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
The code patch fixes the analyzer warning. The code deals with alloc failure in a better way, so that is nice.
wcawijngaards
added a commit
that referenced
this pull request
Jun 19, 2025
- Merge #1297: edns-subnet: fix NULL_AFTER_DEREF on subnetmod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by static analyzer svace.
Static analyzer message: Redundant comparison with a NULL value at subnetmod.c:236 for pointer 'sn_env->subnet_msg_cache', which was dereferenced at slabhash.c:228 by passing as 1st parameter to function 'slabhash_setmarkdel' at subnetmod.c:235.
Moved usage of sn_env->subnet_msg_cache in slabhash_setmarkdel after checking.