Repository navigation
Conversation
wcawijngaards
added a commit
that referenced
this pull request
Sep 3, 2025
Member
|
The make depend, that was run, has produced an output that includes the additional dependencies from the change requested. That means those file dependencies are updated, and it uses the regular dependency method for it, that is preferable. The change is not needed with that fix, hence the pull request is closed without a merge, the commit fixes it in a different way. Thank you for noting the missing dependencies! |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Sep 3, 2025
* nlnet/master: (106 commits) - For NLnetLabs#1328: make depend. - Fix indentation in tcp-mss option parsing. - Fix NLnetLabs#1324: Memory leak in 'msgparse.c' in 'parse_edns_options_from_query(...)'. - Fix NLnetLabs#1235: Outdated Python2 code in unbound/pythonmod/examples/log.py. - Fix for NLnetLabs#1324: Fix to free edns options scratch in ratelimit case. - Limit the number of consecutive reads on an HTTP/2 session. Thanks to Gal Bar Nahum for exposing the possibility of infinite reads on the session. - Fix setup_listen_sslctx warning for nettle compile. - Fix unbound-control dump_cache for double unlock of lruhash table. Changelog entry. - Fix unbound-control dump_cache for double unlock of lruhash table. - Fix ports workflow to install expat for macos. - Fix that the zone acquired timestamp is set after the zonefile is read. - Fix NLnetLabs#1319: [FR] zone status for Unbound auth-zones. - Fix sha1 enable environment variable in test code on windows. - For NLnetLabs#1318: Fix compile warnings for DoH compile on windows. - Fix for NLnetLabs#1317: Fix contrib/unbound.service comment path for systemd network configuration. - Fix NLnetLabs#1317: Unbound starts too early. Add Wants=network-online.target under [Unit] in unbound.service. - Fix to check for extraneous command arguments for unbound-control, when the command takes no arguments but there are arguments present. Changelog note for the fix. - Fix to check for extraneous command arguments for unbound-control, when the command takes no arguments but there are arguments present. - Fix cache_lookup subnet print to not print messages without rrsets and perform in-depth check on node in the addrtree. - Fix cache_lookup subnet print to not print messages without rrsets and perform in-depth check on node in the addrtree. ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the Makefile. Specifically, previously, any modifications of files like validator/val_nsec3.h would not trigger a rebuild of stats.o. The PR fixes this by including them as additional dependencies.