Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unbound-control view_local_datas_remove command #156

Merged
merged 2 commits into from Jan 29, 2020

Conversation

n3bul4
Copy link
Contributor

@n3bul4 n3bul4 commented Jan 29, 2020

I thought this would be a neat feature, to be able to bulk remove local_data from a view.

@n3bul4 n3bul4 requested a review from wcawijngaards Jan 29, 2020
@ralphdolmans ralphdolmans self-assigned this Jan 29, 2020
@ralphdolmans ralphdolmans requested review from ralphdolmans and removed request for wcawijngaards Jan 29, 2020
Copy link
Contributor

@ralphdolmans ralphdolmans left a comment

Thanks, the code looks good.
One thing; the new command should be also be added to unbound-control.8.in.

Copy link
Contributor

@ralphdolmans ralphdolmans left a comment

looks good, thanks

@ralphdolmans ralphdolmans merged commit d82de65 into NLnetLabs:master Jan 29, 2020
1 check passed
@ralphdolmans
Copy link
Contributor

ralphdolmans commented Jan 29, 2020

Parentheses is unbound-control.c:761 are incorrect, fixed in 5fcae2f

n3bul4 added a commit to n3bul4/FreeBSD-ports that referenced this pull request Feb 10, 2020
The corresponding unbound functionality has already been merged
to unbound master branch:
	NLnetLabs/unbound#156
n3bul4 added a commit to n3bul4/FreeBSD-ports that referenced this pull request Feb 11, 2020
dhcpleases sends a SIGHUP to unbound on every lease change to update DNS
entries. This can lead to long unbound reload times, making DNS queries
fail. This changes solve the problem by using unbound-control to update
DNS entries.

 - kevent to exit when unbound exits
 - removed obsolete parameter -p (pidfile)
 - added bulk remove. See: NLnetLabs/unbound#156
 - added usage

See: Bug #5413
n3bul4 added a commit to n3bul4/FreeBSD-ports that referenced this pull request Feb 11, 2020
Use unbound-control to update DNS entries

dhcpleases sends a SIGHUP to unbound on every lease change to update DNS
entries. This can lead to long unbound reload times, making DNS queries
fail. This changes solve the problem by using unbound-control to update
DNS entries.

 - kevent to exit when unbound exits
 - removed obsolete parameter -p (pidfile)
 - added bulk remove. See: NLnetLabs/unbound#156
 - added usage

See: Bug #5413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants