Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android to Travis testing #174

Closed
wants to merge 2 commits into from
Closed

Add Android to Travis testing #174

wants to merge 2 commits into from

Conversation

noloader
Copy link
Contributor

@noloader noloader commented Feb 29, 2020

Add Android armv7a, aarch64, x86 and x86_64 to Travis testing.

This rig will work for Android NDK-r19c, NDK-r20b and NDK-r21. The Android folks will probably break it some time in the future. The Android folks change tools and directories so we have to fix our scripts. It happens every two or three years or so.

The Android tests are failing at the moment due to GH #175. In the 175 issue, OpenSSL was configured with no-engine. I believe PR #176 fixes it.

The Unbound folks will need to add the copyright and license information if the PR is accepted.

@gthess gthess self-assigned this Mar 2, 2020
@gthess
Copy link
Member

gthess commented Mar 2, 2020

Thanks for this!

One thing that is not clear to me:

The Unbound folks will need to add the copyright and license information if the PR is accepted.

Are you referring to the text NLnet Labs adds to the start of the files or something android related?

@noloader
Copy link
Contributor Author

noloader commented Mar 2, 2020

Hi @gthess,

Are you referring to the text NLnet Labs adds to the start of the files ...

Yes.

gthess added a commit that referenced this pull request Mar 2, 2020
- Move android build scripts to contrib/ and allow android tests to fail.
@gthess
Copy link
Member

gthess commented Mar 2, 2020

Already merged this through the command line but before the last merge commit above and github does not see this PR as merged.
Also moved the android build scripts to contrib/ and marked the android builds as "allowed to fail" in case of future changes on the android world.
Thanks!

@gthess gthess closed this Mar 2, 2020
@noloader
Copy link
Contributor Author

noloader commented Mar 2, 2020

@gthess,

Sounds good.

Someone was asking about Android on the mailing list recently at libunbound on android. It looks like it was good timing.


It also looks like the change made its way to downstream:

$ git merge upstream/master
Merge made by the 'recursive' strategy.
 .travis.yml                                     | 22 ++++++++++++++++++----
 README-Travis.md                                | 18 +++++++++---------
 {android => contrib/android}/15-android.conf    |  0
 {android => contrib/android}/install_expat.sh   |  0
 {android => contrib/android}/install_ndk.sh     |  0
 {android => contrib/android}/install_openssl.sh |  2 +-
 {android => contrib/android}/setenv_android.sh  |  0
 doc/Changelog                                   |  2 ++
 8 files changed, 30 insertions(+), 14 deletions(-)
 rename {android => contrib/android}/15-android.conf (100%)
 rename {android => contrib/android}/install_expat.sh (100%)
 rename {android => contrib/android}/install_ndk.sh (100%)
 rename {android => contrib/android}/install_openssl.sh (94%)
 rename {android => contrib/android}/setenv_android.sh (100%)

@noloader
Copy link
Contributor Author

noloader commented Mar 2, 2020

@gthess,

It may be a good idea to update config.guess and config.sub. The existing ones are from 2016. I believe the newer ones have better support for NetBSD and Android (among other fixes).

You can fetch the latest config.guess and config.sub with:

wget -O config.guess 'https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD'
wget -O config.sub 'https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.sub;hb=HEAD'
chmod a+x config.guess config.sub

Also see config.guess, config.sub at top level in the GNU manual.

@gthess
Copy link
Member

gthess commented Mar 2, 2020

Good point, I can look into it.
Do you bring it up because you encountered an issue or just noticed?

@gthess
Copy link
Member

gthess commented Mar 3, 2020

Updated on 114d650.

@noloader
Copy link
Contributor Author

noloader commented Mar 3, 2020

@gthess ,

Do you bring it up because you encountered an issue or just noticed?

No, no problems detected. It was just something I noticed while poking around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants