Update README-Travis.md#179
Closed
noloader wants to merge 0 commit intoNLnetLabs:masterfrom
noloader:master
Closed
Update README-Travis.md#179noloader wants to merge 0 commit intoNLnetLabs:masterfrom noloader:master
noloader wants to merge 0 commit intoNLnetLabs:masterfrom
noloader:master
Conversation
Contributor
|
Hi, Is this PR closed on purpose? The changes seem valuable to me. |
Contributor
Author
|
Hi @ralphdolmans, It looks like it got closed automatically when I sync'd with upstream (more correctly, during the push). I think the change should be merged. Would you like another PR? Or can you work with this PR? |
Contributor
|
No problem, I can work with this PR. Thanks! |
Contributor
Author
|
In case it helps: README-Travis.md.zip. It has the original changes from the PR and one small update. The update is due to merging "don't call exit in Travis script" PR today. |
ralphdolmans
added a commit
that referenced
this pull request
Mar 4, 2020
Contributor
|
Thanks again! Commited the changes to master in cd6bb00. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates README-Travis.md.
The first change adds section headers to the steps used in Android testing. The second change adds a few additional sections, like building the prereqs OpenSSL and Expat. Another section added is Developer Workstation, which discusses sharp edges for developers.
The PR also removes some additional legacy NDK gear from OpenSSL's 15-android.conf.