New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenSSL cross-compaile warnings #201
Conversation
warning: '__ANDROID_API__' macro redefined
@@ -65,7 +84,7 @@ case "$AOSP_CPU" in | |||
CXXFLAGS="-march=armv7-a -mthumb -mfloat-abi=softfp -funwind-tables -fexceptions -frtti" | |||
;; | |||
|
|||
armv8|armv8a|aarch64|arm64|arm64-v8a) | |||
armv8*|aarch64|arm64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it supposed to be arm64*
here or the change is indeed intended?
The arm64-v8a
option is not accounted for anymore but I also see that we don't use it with travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Android uses arm64
alone. But arm64*
should be fine too. arm64*
will help users who do something like ANDROID_CPU=arm64-v8a
. I'd make the change if I were you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gthess, I grabbed the change for Crypto++ at Commit ccb3e869eddd. Thanks.
- Merge PR #201 from noloader: Fix OpenSSL cross-compaile warnings.
This PR cleans up OpenSSL warnings when cross-compiling. It also uses the same
15-android.conf
andsetenv-android.sh
as Unbound.OpenSSL has a penchant for ignoring user flags. When Travis jobs were added that used
ANDROID_API=23
(the minimum) it produced warnings like the following because OpenSSL stomped on Unbound's flags.The issue is cleared by removing the function
android_ndk
from15-android.conf
.A sample build with the noisy warnings is available here