Add start_time to reply callbacks so modules can compute the response… #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
The struct timeval should be passed with a ptr instead of a structure function argument. This is much easier for function signature, also for dynamic libraries and different compilers. The python start time calculation has a casting issue, losing fractions. Indentation (but that may be because of the view here). I approve of the changes, allows modules to access more information. The callbacks get either 0 or the value from the packet if also packets exist for that query, but that seems fine now, not really a need to add a timer value to the callbacks.
wcawijngaards
added a commit
that referenced
this pull request
Jan 8, 2021
- Merge PR #391 from fhriley: Add start_time to reply callbacks so modules can compute the response time.
wcawijngaards
added a commit
that referenced
this pull request
Jan 8, 2021
wcawijngaards
added a commit
that referenced
this pull request
Jan 8, 2021
wcawijngaards
added a commit
that referenced
this pull request
Jan 8, 2021
|
Thanks for the patch! Applied with a number of small changes. |
|
As an aside, the cast in the python start time looks like it was fine upon a further look; but I added explicit casts. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 20, 2021
* nlnet/master: (33 commits) rpl tests for nsid example.conf.in entry for nsid - Fix declaration before statement and signed comparison warning in dns64. - Fix NLnetLabs#404: DNS query with small edns bufsize fail. Changelog entry for NLnetLabs#402. - Merge NLnetLabs#402 from fobser: Implement IPv4-Embedded addresses according to RFC6052. Implement IPv4-Embedded addresses according to RFC6052. - Fix for NLnetLabs#93: dynlibmodule import library is named libunbound.dll.a. - Fix for NLnetLabs#93: dynlibmodule link fix for Windows. Nicer changelog note for NLnetLabs#399 - Merge NLnetLabs#399 from xiangbao227: The lock of lruhash table should unlocked after markdel entry. Changelog note for NLnetLabs#399 - Merge NLnetLabs#399 from xiangbao227: The function rrset_cache_touch can touch an entry to the lru while markdelling the entry in lruhash_remove. I found that in function lruhash_remove, table was locked at first ,then lru_remove the entry , then unlock the table, and then markdel entry , but in function rrset_cache_touch , the entry will be touched to lru again before markdelling entry in function lruhash_remove. This is a bug! And man page documentation for them. - Fix so local zone types always_nodata and always_deny can be used from the config file. - Fix NLnetLabs#397: [Feature request] add new type always_null to local-zone similar to always_nxdomain. - Fix clang analysis warning. - Add comment documentation. - For NLnetLabs#391: more double casts in python start time calculation. - For NLnetLabs#391: fix indentation. - For NLnetLabs#391: use struct timeval* start_time for callback information. Changelog note for NLnetLabs#391 - Merge PR NLnetLabs#391 from fhriley: Add start_time to reply callbacks so modules can compute the response time. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… time.