Prevent a few more yacc clashes. #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthess
added a commit
that referenced
this pull request
Jan 26, 2021
- Merge PR #408 from fobser: Prevent a few more yacc clashes.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 30, 2021
* nlnet/master: (34 commits) - Fix for doxygen 1.8.20 compatibility. - Fix fwd ancil test post script when not supported. - Fix empty clause warning in edns pass for padding. - Fix to use correct type for label count in ipdnametoaddr rpz routine. - Fix empty clause warning in config_file nsid parse. - Fix to use correct type for label count in rpz routine. - Annotate that we ignore the return value of if_indextoname. - Fix compile of unbound-dnstap-socket without dnstap installed. - Ignore cache blacklisting when trying to reply with expired data from cache. (NLnetLabs#394) Changelog entry for: - Merge PR NLnetLabs#355 from noloader: Make ICANN Update CA and DS Trust Anchor static data. Changelog entry for: - Merge PR NLnetLabs#275 by Roland van Rijswijk-Deij, Add feature to return the original instead of a decrementing TTL ('serve-original-ttl'). Changelog entry for: - Merge PR NLnetLabs#408 from fobser: Prevent a few more yacc clashes. - Update example.con.in and add a testcase for PR NLnetLabs#275. Some review nits from George Test some different padding sizes padding.tdir text in single TXT RR tdir test for padding option Addressed review comment from @wcawijngaards Changelog entry for padding option Move NSID Changelog entry to day of merge ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these might cause problems when using libunbound in a program that itself uses yacc and compiling with -fno-common.
I spotted it in unwind(8) when trying to make it clang11 ready which has -fno-common on by default.
unwind link in libunbound statically and has its own peculiar make system so this might be self-inflicted or not
actually happing for other libunbound users.
In any case it would be appreciated if this could be merged, it will make my life easier and shouldn't cause harm for unbound.