Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add missing linker flags. #449

Merged
merged 1 commit into from Mar 22, 2021
Merged

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Mar 21, 2021

When building unbound with --with-pyunbound and slibtool (https://dev.midipix.org/cross/slibtool) it fails with many python undefined references.

This is because the $(LIBTOOL) linker command has -no-undefined and forgot $(LIB) which when added solves the problem. GNU libtool does not expose this issue because it silently ignores -no-undefined.

Full build log: unbound.slibtool.log

Edit: Also see this downstream issue.

https://bugs.gentoo.org/777447

@wcawijngaards wcawijngaards merged commit 5afda55 into NLnetLabs:master Mar 22, 2021
wcawijngaards added a commit that referenced this pull request Mar 22, 2021
@wcawijngaards
Copy link
Member

Thanks for the fix! Merged it into the code repository.

@orbea orbea deleted the build branch March 22, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants