Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of TCP timeout while waiting for response #478

Merged
merged 1 commit into from May 4, 2021

Conversation

edevil
Copy link
Contributor

@edevil edevil commented Apr 27, 2021

This allows us to configure how long Unbound will wait for a response
on a TCP connection.

Related to #470

Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the additional config setting, perhaps it can help if there are connection issues with (certain types of) upstream TCP servers.

This allows us to configure how long Unbound will wait for a response
on a TCP connection.
@edevil
Copy link
Contributor Author

edevil commented Apr 28, 2021

Resolved conflicts.

@edevil
Copy link
Contributor Author

edevil commented May 3, 2021

@wcawijngaards Do you want me to make further changes to this PR?

@wcawijngaards wcawijngaards merged commit 09b924f into NLnetLabs:master May 4, 2021
wcawijngaards added a commit that referenced this pull request May 4, 2021
- Merge #478: Allow configuration of TCP timeout while waiting for
  response.
@wcawijngaards
Copy link
Member

No changes are needed, I merged the patch. The features could be useful for people that want to configure tcp behaviour. Thanks for the patch!

jedisct1 added a commit to jedisct1/unbound that referenced this pull request May 9, 2021
* nlnet/master:
  - Remove case fallthrough from deprecate-rsa-1024 code.
  - Add ./configure --with-deprecate-rsa-1024 that turns off RSA 1024.
  - Fix NLnetLabs#485: Unbound occasionally reports broken stats.
  - Rerun flex and bison.
  - Fix to squelch tcp socket bind failures when the interface is gone.
  - Add more logging for out-of-memory cases.
  - Fix for NLnetLabs#367: only attempt to get the interface for queries   that are no longer on the tcp_waiting_list.
  Clearer template text since not everyone can reopen GitHub issues.
  Changelog note for NLnetLabs#478 - Merge NLnetLabs#478: Allow configuration of TCP timeout while waiting for   response.
  Changelog note and improved comment. - Fix NLnetLabs#481: Fix comment in configuration file.
  doc/example.conf.in: Clarify comment for `auto-trust-anchor-file`
  - Add that log-servfail prints an IP address and more information   about one of the last failures for that query.
  Allow configuration of TCP timeout while waiting for response
  Create issue templates
  - Fix compiler warning for signed/unsigned comparison for   max_reuse_tcp_queries.
  - Fix NLnetLabs#474: always_null and others inside view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants