Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of libunbound.pc #493

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix generation of libunbound.pc #493

merged 1 commit into from
Dec 1, 2021

Conversation

Jakker
Copy link
Contributor

@Jakker Jakker commented May 24, 2021

According to a PR at FreeBSD ports a broken libunbound.pc file is installed.

This is the proposed patch for it.

Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot just remove these flags for everyone, that would be wrong. From the link you cite, it seems like it needs to be removed if libcrypto and openssl are from the FreeBSD base system. And it should be present when openssl is from ports or on other systems. Thus also the patch, if deployed in the code repository of unbound, has to detect whether this is the FreeBSD base system openssl, before selecting the value of PC_CRYPTO_DEPENDENCY. In the link cited, the developer seems to suggest putting this diff in the package system of FreeBSD; and I guess that sort of detects what openssl is used; but may also be a Makefile that is used for both base system openssl and ports installed openssl.

@wcawijngaards
Copy link
Member

However, is a requires line, and not the LIBS line, I misread that. Much less harmful if we remove that for everyone; they may compile without proper requirements, but the linking works fine if they have openssl somehow. So I guess, since it just drops the requirement checks from pkg-config, it won't fail the compile for a whole bunch of systems; so if you want I do not mind applying this change so the pkg-config file, in our contrib/ that is requested.

Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it solves matters as people suggest, I do not see compile failure inducing blockers.

@gthess gthess merged commit a22a795 into master Dec 1, 2021
@gthess gthess deleted the patch-configure branch December 1, 2021 02:50
gthess added a commit that referenced this pull request Dec 1, 2021
    - Merge PR #493 from Jaap: Fix generation of libunbound.pc.
jedisct1 added a commit to jedisct1/unbound that referenced this pull request Jan 13, 2022
* nlnet/master: (36 commits)
  - Add missing configure flags for optional features in the   documentation. - Fix Unbound capitalization in the documentation.
  - Fix to pick up other class local zone information before unlock.
  - Allow local-data for classes other than IN to inherit a configured   local-zone's type if possible, instead of defaulting to type   transparent as per the implicit rule.
  - Add code similar to fix for ldns for tab between strings, for   consistency, the test case was not broken.
  Continue with version 1.14.1
  - Fix validator debug output about DS support, print correct algorithm.
  Changelog note for NLnetLabs#581
  Fix -Wshadow
  Fix -Wmissing-prototypes by declaring functions static.
  - Fix compile warning for if_nametoindex on windows 64bit.
  - Fix doc/unbound.doxygen to remove obsolete tag warning.
  - configure is set to 1.14.0, and release branch.
  - Fix NLnetLabs#574: Review fixes for size allocation.
  - Fix NLnetLabs#454: listen_dnsport.c:825: error: ‘IPV6_TCLASS’ undeclared.
  Changelog note for NLnetLabs#530:     - Merge PR NLnetLabs#530 from Shchelk: Fix: dereferencing a null pointer.
  Changelog note for NLnetLabs#522:     - Merge PR NLnetLabs#522 from sibeream: memory management violations fixed.
  Changelog note for NLnetLabs#562:     - Merge PR NLnetLabs#562 from Willem: Reset keepalive per new tcp session.
  Changelog note for NLnetLabs#555:     - Merge PR NLnetLabs#555 from fobser: Allow interface names as scope-id in       IPv6 link-local addresses.
  Changelog note for NLnetLabs#493:     - Merge PR NLnetLabs#493 from Jaap: Fix generation of libunbound.pc.
  Changelog note for NLnetLabs#511:     - Merge PR NLnetLabs#511 from yan12125: Reduce unnecessary linking.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants