Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: passed to proc after free #531

Merged
merged 1 commit into from Aug 20, 2021
Merged

Conversation

Shchelk
Copy link
Contributor

@Shchelk Shchelk commented Aug 20, 2021

Found by static analyzer svace
Static analyzer message: Pointer 'dp' is passed to a function at iter_hints.c:401 after the referenced memory was deallocated at iter_hints.c:174 by passing as 3rd parameter to function 'hints_insert' at iter_hints.c:398.

on-behalf-of: @ideco-team github@ideco.ru

Found by static analyzer svace
Static analyzer message: Pointer 'dp' is passed to a function at
iter_hints.c:401 after the referenced memory was deallocated at
iter_hints.c:174 by passing as 3rd parameter to function 'hints_insert'
at iter_hints.c:398.

on-behalf-of: @ideco-team <github@ideco.ru>
@wcawijngaards wcawijngaards merged commit 1ae42b9 into NLnetLabs:master Aug 20, 2021
@wcawijngaards
Copy link
Member

Thank you for the fix. The ignored double entry causes the problem here, but it is still good to deallocate, so the fix is the right one.

wcawijngaards added a commit that referenced this pull request Aug 20, 2021
- Fix #531: Fix: passed to proc after free.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants