Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound.service.in: Disable ProtectKernelTunables again #565

Merged
merged 1 commit into from
Nov 5, 2021
Merged

unbound.service.in: Disable ProtectKernelTunables again #565

merged 1 commit into from
Nov 5, 2021

Conversation

Maryse47
Copy link
Contributor

@Maryse47 Maryse47 commented Nov 3, 2021

This option was removed in ff8fd0b but reintroduced in c32b9e4

Disable it with commentary in hope to prevent slipping it in again.

cc: @ArchangeGabriel

This option was removed in ff8fd0b but reintroduced in c32b9e4

Disable it with commentary in hope to prevent slipping it in again.
@Maryse47
Copy link
Contributor Author

Maryse47 commented Nov 5, 2021

@wcawijngaards could you take a look at this one?

Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it makes sense to stop this from getting removed and added again to protect, in a cycle.

@wcawijngaards wcawijngaards merged commit 7df1a34 into NLnetLabs:master Nov 5, 2021
wcawijngaards added a commit that referenced this pull request Nov 5, 2021
- Merge #565: unbound.service.in: Disable ProtectKernelTunables again.
@ArchangeGabriel
Copy link
Contributor

Sorry, I should have looked at the file history. Explicitly disabling is a good idea indeed.

@Maryse47 Maryse47 deleted the patch-1 branch November 5, 2021 20:41
jedisct1 added a commit to jedisct1/unbound that referenced this pull request Nov 18, 2021
* nlnet/master: (23 commits)
  Document PR NLnetLabs#563 to changelog
  Clarify KEEPALIVE EDNS0 option operation
  Make explicit whether edns options are parsed from queries or responses
  add missing return code
  Remove wrongly added EDE comments
  Update util/data/msgparse.c
  add potential EDE spots
  complete renaming of the modules edns list
  Apply suggestions from code review
  Changelog note for NLnetLabs#565 - Merge NLnetLabs#565: unbound.service.in: Disable ProtectKernelTunables again.
  - Fix to remove unused code from rpz resolve client and action   function.
  - Fix analyzer review failure in rpz action override code to not   crash on unlocking the local zone lock.
  - Fix for NLnetLabs#558: clear the UB_EV_TIMEOUT bit before adding an event.
  - Fix for NLnetLabs#558: fix loop in comm_point->tcp_free when a comm_point is reclaimed   more than once during callbacks.
  - Fix that forward-zone name is documented as the full name of the   zone. It is not relative but a fully qualified domain name.
  Disable ProtectKernelTunables again
  - Fix NLnetLabs#552: Unbound assumes index.html exists on RPZ host.
  Fix keepalive logic
  Move option handling to parse-time
  split edns_data.opt_list in opt_list_in and opt_list_out
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants