Add the basic EDE (RFC8914) cases - #604
Merged
Merged
Conversation
+ complete EDE codes
This reverts commit b3f60db.
when refusing to answer authoritatively. Also remove TODO comments that were already done
…fluous todo comments
wcawijngaards
approved these changes
Mar 10, 2022
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
Code looks good! Hopefully the review fixes a couple of issues.
gthess
requested changes
Apr 21, 2022
gthess
left a comment
gthess
left a comment
Member
There was a problem hiding this comment.
Nice work! Here is the first part of the review (missing review of validator.c and all the test cases).
The review comments are mostly nits but there are also some suggestions and some changes that I would like to see.
I'll start working on the second part of the review.
Comment on lines
+1295
to
+1296
| m->s.env->need_to_validate && (!(r->qflags&BIT_CD) || | ||
| m->s.env->cfg->ignore_cd) && rep && |
Member
TCY16
changed the title
…g superfluous _ede functions in the validator
…and change logic accordingly, and change validator logic to be more careful with EDE overwrites and change logic accordingly
gthess
requested changes
May 1, 2022
gthess
left a comment
gthess
left a comment
Member
There was a problem hiding this comment.
Finished the second part of the review.
Mostly nits (with clickable suggestions) but I believe a couple of tests should expect a different EDE value.
Co-authored-by: gthess <george@nlnetlabs.nl>
…e logic, remove superfluous test cases
…hange coresponding tests
gthess
requested changes
May 4, 2022
gthess
left a comment
gthess
left a comment
Member
There was a problem hiding this comment.
Seems good!
Only thing that is pending is changing serve-expired-ede to ede-serve-expired and checking the global ede option together with that option.
Maybe also renaming the global option to just ede for easier grouping with the (future) ede options/toggles as discussed.
…g the global ede option together with that option
TCY16
added a commit
that referenced
this pull request
May 6, 2022
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
May 25, 2022
* nlnet/master: - Fix some lint type warnings. - Fix ede test to not use default pidfile, and use local interface. - Fix to silence test for ede error output to the console from the test setup script. - Fix typos in config_set_option for the 'num-threads' and 'ede-serve-expired' options. - Fix NLnetLabs#678: [FR] modify behaviour of unbound-control rpz_enable zone, by updating unbound-control's documentation. - For NLnetLabs#677: Added tls-system-cert to config parser and documentation. - Changelog note for NLnetLabs#677. Allow using system certificates not only on Windows - Fix NLnetLabs#417: prefetch and ECS causing cache corruption when used together. - Fix NLnetLabs#673: DNS over TLS: error: SSL_handshake syscall: No route to host. - Fix Python build in non-source directory; based on patch by Michael Tokarev. Changelog entry for NLnetLabs#604: Add the basic EDE (RFC8914) cases Add the basic EDE (RFC8914) cases (NLnetLabs#604) - Fix NLnetLabs#670: SERVFAIL problems with unbound 1.15.0 running on OpenBSD 7.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this branch is a split from #504 which implements all the easier EDE cases.