-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ED25519 and ED448 in FIPS mode on openssl3 #671
Disable ED25519 and ED448 in FIPS mode on openssl3 #671
Conversation
7b2e3d2
to
32cce8a
Compare
What is FIPS mode for and how can it be used is written in RHEL documentation: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/security_hardening/assembly_installing-a-rhel-8-system-with-fips-mode-enabled_security-hardening |
Both crypto functions are not allowed by FIPS 140-3. Use openssl 3.0 function to check FIPS mode presence and use it to make those algorithms unsupported.
32cce8a
to
917c30a
Compare
Any comments for this change? |
Although the code LGTM, I find the change very implicit i.e., if "just fips" is set, disable those algorithms. |
It works around the resolution failure in FIPS mode:
After this change the result in FIPS mode would switch just to insecure, but still to successful resolution. Of course unbound itself would be affected too. |
I expect FIPS mode is not enabled in openssl unless there is a reason for it to be. This might change once those algorithms are accepted by FIPS 140-3. It is expected they might and would be, but not clear when. This change can be reverted once they are acceptable. |
Making security worse for "compliance" is sad. |
- Merge PR #671 from Petr Menšík: Disable ED25519 and ED448 in FIPS mode on openssl3.
Both crypto functions are not allowed by FIPS 140-3. Use openssl 3.0
function to check FIPS mode presence and use it to make those algorithms
unsupported.
Would allow flawless fallback to insecure results for ED25519, ED448 and also SHA-1 algorithms.