Allow using system certificates not only on Windows #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL has a way to load default file. That file might contain usable certificates to verify common connections. Allow similar trust as on windows and leave it on openssl package to provide sane defaults. Also provide use-system-cert alias, because it is not windows specific anymore.
wcawijngaards
approved these changes
May 12, 2022
wcawijngaards
added a commit
that referenced
this pull request
May 12, 2022
- Changelog note for #677.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
May 25, 2022
* nlnet/master: - Fix some lint type warnings. - Fix ede test to not use default pidfile, and use local interface. - Fix to silence test for ede error output to the console from the test setup script. - Fix typos in config_set_option for the 'num-threads' and 'ede-serve-expired' options. - Fix NLnetLabs#678: [FR] modify behaviour of unbound-control rpz_enable zone, by updating unbound-control's documentation. - For NLnetLabs#677: Added tls-system-cert to config parser and documentation. - Changelog note for NLnetLabs#677. Allow using system certificates not only on Windows - Fix NLnetLabs#417: prefetch and ECS causing cache corruption when used together. - Fix NLnetLabs#673: DNS over TLS: error: SSL_handshake syscall: No route to host. - Fix Python build in non-source directory; based on patch by Michael Tokarev. Changelog entry for NLnetLabs#604: Add the basic EDE (RFC8914) cases Add the basic EDE (RFC8914) cases (NLnetLabs#604) - Fix NLnetLabs#670: SERVFAIL problems with unbound 1.15.0 running on OpenBSD 7.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL has a way to load default file. That file might contain usable
certificates to verify common connections. Allow similar trust as on
windows and leave it on openssl package to provide sane defaults.
Also provide use-system-cert alias, because it is not windows specific
anymore.