Fix startup failure on Windows 8.1 due to unsupported IPV6_USER_MTU socket option being set #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocket option being set Newer mingw-w64 (starting from 8.0.1) introduces support for `IPV6_USER_MTU` socket option [1], which is not supported on Windows 8.1 and older [2]. As there is no way to avoid this socket option from being picked at compile time when targeting older versions of Windows, check for `setsockopt(..., IPV6_USER_MTU, ...)` failures at runtime in order to avoid startup failure on those versions of Windows where the `IPV6_USER_MTU` socket option is unsupported. [1]: mirror/mingw-w64@e30bff4 [2]: `WSAGetLastError()` returns `WSAENOPROTOOPT` (`Bad protocol option`) error code
wcawijngaards
approved these changes
Aug 2, 2022
wcawijngaards
added a commit
that referenced
this pull request
Aug 2, 2022
- Merge #730 from luisdallos: Fix startup failure on Windows 8.1 due to unsupported IPV6_USER_MTU socket option being set.
|
Thanks for the fix, this looks similar to the fixes in the links you provided and I also think that it likely works well for users, since it adapts to different support levels at run time. Merged it into the code repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer mingw-w64 (starting from 8.0.1) introduces support for
IPV6_USER_MTUsocket option [1], which is not supported on Windows 8.1 and older [2]. As there is no way to avoid this socket option from being picked at compile time when targeting older versions of Windows, check forsetsockopt(..., IPV6_USER_MTU, ...)failures at runtime in order to avoid startup failure on those versions of Windows where theIPV6_USER_MTUsocket option is unsupported.Fixes #729
[1] : mirror/mingw-w64@e30bff4
[2] :
WSAGetLastError()returnsWSAENOPROTOOPT(Bad protocol option) error codeSee also:
https://sourceforge.net/p/uftp-multicast/discussion/general/thread/257f3c21/
https://stackoverflow.com/questions/49982697/