PROXYv2 downstream support #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Sep 30, 2022
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
from review feedback.
|
Thanks for the review @wcawijngaards! |
gthess
added a commit
that referenced
this pull request
Oct 3, 2022
- Merge #760: PROXYv2 downstream support. (New proxy-protocol-port configuration option).
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Oct 15, 2022
* nlnet/master: (25 commits) - In unit test, print python script name list correctly. Changelog note for NLnetLabs#768 - Merge NLnetLabs#768 from fobser: Arithmetic on a pointer to void is a GNU extension. Arithmetic on a pointer to void is a GNU extension. - Tag for 1.17.0 release. The code repository continues with 1.17.1. - Fix PROXYv2 header read for TCP connections when no proxied addresses are provided. Changelog note for tag for 1.17.0rc1 release. - Fix unit test to properly test the reuse_write_wait_pop function. - Fix to stop possible loops in the tcp reuse code (write_wait list and tcp_wait list). Based on analysis and patch from Prad Seniappan and Karthik Umashankar. - Fix proxy length debug output printout typecasts. - Fix to stop responses with TC flag from resulting in partial responses. It retries to fetch the data elsewhere, or fails the query and in depth fix removes the TC flag from the cached item. - Fix checkconf test for dnscrypt and proxy port. - Fix dnscrypt compile for proxy protocol code changes. - Make ede.tdir test more predictable by using static data. - Use DEBUG_TDIR from environment in mini_tdir.sh for debugging. - Fix string comparison in mini_tdir.sh. Changelog entry for NLnetLabs#764 - Merge NLnetLabs#764: Leniency for target discovery when under load (for NRDelegation changes). Leniency for target discovery when under load (for NRDelegation changes) (NLnetLabs#764) - Fix to clean up after the acl_interface unit test. - Fix static analysis report to remove dead code from the rpz_callback_from_iterator_module function. - Fix to close errno block in comm_point_tcp_handle_read outside of ifdef. Changelog entry for NLnetLabs#760 - Merge NLnetLabs#760: PROXYv2 downstream support. (New proxy-protocol-port configuration option). ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase from https://github.com/gthess/unbound/tree/proxy_protocol_2_wip for downstream PROXYv2 support.
Progress:
How to use:
Take a normal Unbound configuration and add
for the port you want to listen for PROXYv2.
The port needs to be an already defined listening port.
You can add the option multiple times for more ports.
Unbound will expect PROXYv2 there.
The proxied client information should be used for everything except for the actual network communication.