Wrap Makefile script's directory variables in quotes #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes have not been tested so as to not affect other platforms/toolchains; a reviewer ought to make sure that the main hosts/targets aren't compromised. |
sneurlax
added a commit
to sneurlax/flutter_libwownero
that referenced
this pull request
Dec 13, 2022
wcawijngaards
approved these changes
Dec 13, 2022
wcawijngaards
added a commit
that referenced
this pull request
Dec 13, 2022
- Merge #808: Wrap Makefile script's directory variables in quotes.
|
Thanks for the fix! Merged it into the code repository. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Dec 13, 2022
* nlnet/master: - Updates for NLnetLabs#461 (Add max-query-restarts option). - Expose 'max-sent-count' as a configuration option; the default value retains Unbound's behavior. - Expose 'statistics-inhibit-zero' as a configuration option; the default value retains Unbound's behavior. - Fix to wrap Makefile scripts directory in quotes for uninstall. Changelog note for NLnetLabs#808 - Merge NLnetLabs#808: Wrap Makefile script's directory variables in quotes. wrap directory variables in quotes Fix date. - Fix NLnetLabs#773: When used with systemd-networkd, unbound does not start until systemd-networkd-wait-online.service times out. - Clear documentation for interactivity between the subnet module and the serve-expired and prefetch configuration options. - Add SVCB and HTTPS to the types removed by 'unbound-control flush'. - Fix NLnetLabs#782: Segmentation fault in stats.c:404. Changelog entry for NLnetLabs#720 Document max-query-restarts option Use max-query-restarts in iterative resolver Add max-query-restarts to grammar and lexer Add max-query-restarts config parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request wraps the directory variables on line 619 of Makefile.in in quotes so as to avoid
make installfailure due to a script parsing error as seen in #807