Аdd a metric about the maximum number of collisions in lrushah #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Jan 13, 2023
wcawijngaards
added a commit
that referenced
this pull request
Jan 13, 2023
- Merge #826: Аdd a metric about the maximum number of collisions in lrushah.
|
Thanks for the additional performance counter! Perhaps it can prevent other issues like this. I have merged it in to the code repository. Also documentation is added, for the statistics entries, do you like the text for it; it can be seen in the commit 469133e ? |
|
It looks very good, thank you! Perhaps it was worth writing |
wcawijngaards
added a commit
that referenced
this pull request
Jan 13, 2023
|
Okay, improved the wording to add that detail! Useful to know what amount is trouble. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 15, 2023
* nlnet/master: - Improve documentation for NLnetLabs#826, describe the large collisions amount. Changelog note and documentation for NLnetLabs#826 - Merge NLnetLabs#826: Аdd a metric about the maximum number of collisions in lrushah. add a metric about the maximum number of collisions in lrushah Code repository continues with version 1.17.2. - Fix python version detection in configure. - Fix python module install path detection. Changelog note for 1.17.1rc2 fix. - Fix wildcard in hyperlocal zone service degradation, reported by Sergey Kacheev. This fix is included in 1.17.1rc2. - Fix wildcard in hyperlocal zone service degradation, reported by Sergey Kacheev. - Fix NLnetLabs#823: Response change to NODATA for some ANY queries since 1.12, tested on 1.16.1. Changelog note for tag for 1.17.1rc1. - Tag for 1.17.1 release. Add Mastodon link Add Mastodon - Update github workflows to use checkout v3. - Fix windows compile for libunbound subprocess reap comm point closes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of the fix added here 90831af
I would like to suggest adding a metric about the maximum number of collisions that happened in lruhash.
This will be the best indicator of a similar problem in the future.