Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded -b / source address option to smallapp/unbound-anchor.c #86
Conversation
wcawijngaards
added a commit
that referenced
this pull request
Oct 3, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for the patch, that is a useful feature and nice code! Merged. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Oct 7, 2019
* nlnet/master: - Add doxygen comments to unbound-anchor source address code, in NLnetLabs#86. For NLnetLabs#86, note credit for Lukas Wunner. Changelog entry for NLnetLabs#86 and whitespace fix. - Merge NLnetLabs#86 from psquarejho: Added -b source address option to smallapp/unbound-anchor.c. - Merge 1.9.4 release with fix for vulnerability CVE-2019-16866. - Continue with development of 1.9.5. Branch 1.9.4 prepares for 1.9.4 release from 1.9.3 Changelog entry for Merge NLnetLabs#90. - Merge NLnetLabs#90 from vcunat: fix build with nettle-3.5. fix build with nettle-3.5 Added -b / source address option to smallapp/unbound-anchor.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
psquarejho commentedSep 24, 2019
This is a patch which we need for the unbound server at a customer.
It allows you to specify the source address which unbound-anchor uses to connect to the root name servers. This is needed in our case as only the (additional) service ips on an interface are allowed to perform DNS queries, not the base ip of the interface.
Credit for developing this patch goes to Lukas Wunner lukas@wunner.de. I have just been maintaining this patch for the internal packages since 1.4, we just never got around to submit it upstream.
We hope to get this added to main stream unbound, as this is basically the last custom unbound patch we are maintaining.