Skip to content

Add cachedb hit stat #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Add cachedb hit stat #892

merged 5 commits into from
Jun 27, 2023

Conversation

gthess
Copy link
Member

@gthess gthess commented May 31, 2023

No description provided.

@gthess gthess requested a review from wcawijngaards May 31, 2023 10:29
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, check the += vs = for initialisation in stats.c.

gthess and others added 2 commits May 31, 2023 17:09
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
@gthess
Copy link
Member Author

gthess commented Jun 2, 2023

Thanks for the review @wcawijngaards!
I am tagging this for the next release (pending user feedback for merging if it arrives in a timely manner)

@gthess gthess added this to the 1.18.0 milestone Jun 2, 2023
@gthess gthess self-assigned this Jun 2, 2023
@gthess gthess merged commit 41dac80 into master Jun 27, 2023
@gthess gthess deleted the cachedb-hit-stat branch June 27, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants