Check for c99 with autoconf versions prior to 2.70 #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Sep 15, 2023
wcawijngaards
added a commit
that referenced
this pull request
Sep 15, 2023
- Merge #936: Check for c99 with autoconf versions prior to 2.70.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently c99 code snuck into unbound:
https://github.com/NLnetLabs/unbound/blob/master/util/net_help.c#L829
There are some ancient versions of gcc that support c99 but don't default to it, this is the same change as in nsd:
NLnetLabs/nsd@8672db2
See also
NLnetLabs/nsd#222
and
NLnetLabs/nsd#219