From c346164a9a09c6fbe08afb7b6750a48e6d56e613 Mon Sep 17 00:00:00 2001
From: Rolf Kristensen <snakefoot@users.noreply.github.com>
Date: Sat, 12 Aug 2023 15:13:25 +0200
Subject: [PATCH] Updated dependency NLog to v5.2.2 (#170)

---
 azure-pipelines.yml                  |  2 +-
 src/NLog.MailKit/MailTarget.cs       | 25 ++++++++++++++++---------
 src/NLog.MailKit/NLog.MailKit.csproj |  9 +++++----
 3 files changed, 22 insertions(+), 14 deletions(-)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 6cf68d2..7af4cb4 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -13,7 +13,7 @@ variables:
   Solution: 'src/NLog.MailKit.sln'
   BuildPlatform: 'Any CPU'
   BuildConfiguration: 'Release'
-  Version: '5.1.3'
+  Version: '5.1.0'
   FullVersion: '$(Version).$(Build.BuildId)'
 
 steps:
diff --git a/src/NLog.MailKit/MailTarget.cs b/src/NLog.MailKit/MailTarget.cs
index af26068..c1f2131 100644
--- a/src/NLog.MailKit/MailTarget.cs
+++ b/src/NLog.MailKit/MailTarget.cs
@@ -91,7 +91,7 @@ public class MailTarget : TargetWithLayoutHeaderAndFooter
         /// Initializes a new instance of the <see cref="MailTarget" /> class.
         /// </summary>
         /// <remarks>
-        /// The default value of the layout is: <code>${longdate}|${level:uppercase=true}|${logger}|${message:withexception=true}</code>
+        /// The default value of the Body-Layout is: <code>${message}${newline}</code>
         /// </remarks>
         public MailTarget()
         {
@@ -102,7 +102,7 @@ public MailTarget()
         /// Initializes a new instance of the <see cref="MailTarget" /> class.
         /// </summary>
         /// <remarks>
-        /// The default value of the layout is: <code>${longdate}|${level:uppercase=true}|${logger}|${message:withexception=true}</code>
+        /// The default value of the Body-Layout is: <code>${message}${newline}</code>
         /// </remarks>
         /// <param name="name">Name of the target.</param>
         public MailTarget(string name) : this()
@@ -309,7 +309,7 @@ private void ProcessSingleMailMessage(IEnumerable<AsyncLogEventInfo> events)
                 {
                     client.Timeout = RenderLogEvent(Timeout, lastEvent);
 
-                    var renderedHost = SmtpServer.Render(lastEvent);
+                    var renderedHost = RenderLogEvent(SmtpServer, lastEvent);
                     if (string.IsNullOrEmpty(renderedHost))
                     {
                         throw new NLogRuntimeException(string.Format(RequiredPropertyIsEmptyFormat, nameof(SmtpServer)));
@@ -341,8 +341,8 @@ private void ProcessSingleMailMessage(IEnumerable<AsyncLogEventInfo> events)
                     var smtpAuthentication = RenderLogEvent(SmtpAuthentication, LogEventInfo.CreateNullEvent());
                     if (smtpAuthentication == SmtpAuthenticationMode.Basic)
                     {
-                        var userName = SmtpUserName?.Render(lastEvent);
-                        var password = SmtpPassword?.Render(lastEvent);
+                        var userName = RenderLogEvent(SmtpUserName, lastEvent);
+                        var password = RenderLogEvent(SmtpPassword, lastEvent);
 
                         InternalLogger.Debug("Authenticate with username '{0}'", userName);
                         client.Authenticate(userName, password);
@@ -465,9 +465,9 @@ private MimeMessage CreateMailMessage(LogEventInfo lastEvent, string body)
 
             msg.Subject = (RenderLogEvent(Subject, lastEvent) ?? string.Empty).Trim();
 
-            if (Priority != null)
+            var renderedPriority = RenderLogEvent(Priority, lastEvent);
+            if (!string.IsNullOrEmpty(renderedPriority))
             {
-                var renderedPriority = Priority.Render(lastEvent);
                 msg.Priority = ParseMessagePriority(renderedPriority);
             }
 
@@ -477,6 +477,10 @@ private MimeMessage CreateMailMessage(LogEventInfo lastEvent, string body)
             if (html && replaceNewlineWithBrTagInHtml)
             {
                 newBody = newBody?.Replace(Environment.NewLine, "<br/>");
+                if (newBody?.IndexOf('\n') >= 0)
+                {
+                    newBody = newBody?.Replace("\n", "<br/>");
+                }
             }
 
             var encoding = RenderLogEvent(Encoding, lastEvent, DefaultEncoding);
@@ -486,16 +490,19 @@ private MimeMessage CreateMailMessage(LogEventInfo lastEvent, string body)
                 ContentType = { Charset = encoding?.WebName }
             };
 
-
             if (MailHeaders?.Count > 0)
             {
                 for (int i = 0; i < MailHeaders.Count; i++)
                 {
+                    var headerName = MailHeaders[i].Name;
+                    if (string.IsNullOrEmpty(headerName))
+                        continue;
+
                     string headerValue = RenderLogEvent(MailHeaders[i].Layout, lastEvent);
                     if (headerValue is null)
                         continue;
 
-                    msg.Headers.Add(MailHeaders[i].Name, headerValue);
+                    msg.Headers.Add(headerName, headerValue);
                 }
             }
 
diff --git a/src/NLog.MailKit/NLog.MailKit.csproj b/src/NLog.MailKit/NLog.MailKit.csproj
index 5a6c60c..37861c8 100644
--- a/src/NLog.MailKit/NLog.MailKit.csproj
+++ b/src/NLog.MailKit/NLog.MailKit.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
-		<TargetFramework>netstandard2.0</TargetFramework>
+		<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
 		<Authors>Julian Verdurmen</Authors>
 		<Company>NLog</Company>
 		<Description>NLog Mail Target for .NET Core &amp; .NET Standard 2.0+ using MailKit.
@@ -31,7 +31,8 @@ If the mail target was already available on your platform, this package will ove
 		<PackageReleaseNotes>
 - Added support for email headers
 - Added target-alias mailkit
-- Updated to NLog v5.1.3
+- Updated to NLog v5.2.2
+- Updated to MailKit v3.3.0
 
 See https://github.com/NLog/NLog.MailKit/releases
       
@@ -46,11 +47,11 @@ See https://github.com/NLog/NLog.MailKit/releases
 		<DefineConstants>RELEASE</DefineConstants>
 	</PropertyGroup>
 	<ItemGroup>
-		<PackageReference Include="MailKit" Version="3.2.0" />
+		<PackageReference Include="MailKit" Version="3.3.0" />
 		<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
 	</ItemGroup>
 	<ItemGroup>
-		<PackageReference Include="NLog" Version="5.1.3" />
+		<PackageReference Include="NLog" Version="5.2.2" />
 	</ItemGroup>
 	<ItemGroup>
 		<None Include="..\..\README.md">