Handle Breaking change with string.IndexOf(string) in .NET 5 #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried to test myself on Net50-platform, and cannot reproduce the issue. So apparently it is not super urgent to fix on master. |
snakefoot
force-pushed
the
net5_indexof_issue
branch
from
ac95eda
to
1c07868
Compare
snakefoot
force-pushed
the
net5_indexof_issue
branch
from
1c07868
to
e0e1676
Compare
|
Travis-Build Scheduled Now (09:13:07 Local - 08:15:07 GMT) |
|
AppVeyor and Azure Done |
|
The travis-back-log is "only" 3000, when USA was awake then it was 10.000. Only 230 build-engines and each takes 5-10 mins (Seems the total number of available build-engine drops with 5 every day) |
|
Travis Build now running. Started (10:09:03 Local - 09:09:03 GMT) |
|
Travis build broke at 09:13:53 GMT |
|
Kudos, SonarCloud Quality Gate passed! |
304NotModified
changed the title
304NotModified
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggingConfiguration - Expand NLog Config Variables without issues on Net50
Changed from CurrentCultureIgnoreCase to OrdinalIgnoreCase to avoid issue described here: dotnet/runtime#43736
Issue was identified with #4271