New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Breaking change with string.IndexOf(string) in .NET 5 #4273
Conversation
Tried to test myself on Net50-platform, and cannot reproduce the issue. So apparently it is not super urgent to fix on master. |
ac95eda
to
1c07868
Compare
1c07868
to
e0e1676
Compare
Travis-Build Scheduled Now (09:13:07 Local - 08:15:07 GMT) |
AppVeyor and Azure Done |
The travis-back-log is "only" 3000, when USA was awake then it was 10.000. Only 230 build-engines and each takes 5-10 mins (Seems the total number of available build-engine drops with 5 every day) |
Travis Build now running. Started (10:09:03 Local - 09:09:03 GMT) |
Travis build broke at 09:13:53 GMT |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not checked all possible other usages.
LoggingConfiguration - Expand NLog Config Variables without issues on Net50
Changed from CurrentCultureIgnoreCase to OrdinalIgnoreCase to avoid issue described here: dotnet/runtime#43736
Issue was identified with #4271