Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not seem to work with WebpackCompressionPlugin #17

Closed
pmnc-philippe opened this issue Aug 28, 2017 · 2 comments
Closed

Does not seem to work with WebpackCompressionPlugin #17

pmnc-philippe opened this issue Aug 28, 2017 · 2 comments

Comments

@pmnc-philippe
Copy link

hello,
Great plugin ! I have an issue : it does not work with WebpackCompressionPlugin. The compression plugin works fine but the file being compressed is not the file before calling optimize-css-assets-webpack-plugin. This is probably because optimize-css-assets-webpack-plugin uses last-call-webpack-plugin to process the css file at the very last moment, just before emitting to the file - and so compression does not see it.
I am not knowledgeable in architecture of webpack plugin but it seems to be a flaw in optimize-css-assets-webpack-plugin. what else do you think, let me know if you have any plan to fix it ?

@NMFR
Copy link
Owner

NMFR commented Aug 28, 2017

Both plugins seem to use the same event optimize-assets to process the asset. I wonder if changing the order of the plugins in the plugins array will fix it.

Can you provide me with a code sample to test the issue please?

@NMFR
Copy link
Owner

NMFR commented Sep 14, 2017

Should be working in version 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants